[webkit-reviews] review requested: [Bug 25566] REGRESSION: text inputs with "size" are often smaller than before, but sometimes bigger (originally noticed in bugs.webkit.org text fields) : [Attachment 48664] Minor changes to compile on Tiger

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 12 13:54:12 PST 2010


Ojan Vafai <ojan at chromium.org> has asked  for review:
Bug 25566: REGRESSION: text inputs with "size" are often smaller than before,
but sometimes bigger (originally noticed in bugs.webkit.org text fields)
https://bugs.webkit.org/show_bug.cgi?id=25566

Attachment 48664: Minor changes to compile on Tiger
https://bugs.webkit.org/attachment.cgi?id=48664&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
Only changes from patch 46171 are to add the copyFontTableForTag method
(CGFontCopyTableForTag doesn't exist on Tiger) and to move the implementation
of scaleEmToUnits from RenderTextControl.h to RenderTextControl.cpp. Sorry to
add another iteration to this review.


More information about the webkit-reviews mailing list