[webkit-reviews] review granted: [Bug 34507] [Qt] Minor improvement to hybrid QPixmap : [Attachment 48653] The native QPixmap/QImage can now assign its value to an existing image element

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 12 11:48:07 PST 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 34507: [Qt] Minor improvement to hybrid QPixmap
https://bugs.webkit.org/show_bug.cgi?id=34507

Attachment 48653: The native QPixmap/QImage can now assign its value to an
existing image element
https://bugs.webkit.org/attachment.cgi?id=48653&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
Looks fine, but there is at least a minor style issue you could fix before
committing.

> +	   if (hint == qMetaTypeId<QPixmap >())


More information about the webkit-reviews mailing list