[webkit-reviews] review denied: [Bug 34848] Web Inspector: Move JSC-specific Profile and ProfileNode wrappers to bindings/js : [Attachment 48644] instead of replacing, just move those wrappers
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 12 08:26:02 PST 2010
Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 34848: Web Inspector: Move JSC-specific Profile and ProfileNode wrappers to
bindings/js
https://bugs.webkit.org/show_bug.cgi?id=34848
Attachment 48644: instead of replacing, just move those wrappers
https://bugs.webkit.org/attachment.cgi?id=48644&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
I think you should merge JavaScriptProfile into ScriptProfile. JavaScriptNode
also should be simply ScriptNode, both encapsulating JSC specifics. There is no
more need in typedefs.
More information about the webkit-reviews
mailing list