[webkit-reviews] review granted: [Bug 34878] [Chromium] Provide for a frame-specific cookie jar : [Attachment 48627] v1 patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 34878: [Chromium] Provide for a frame-specific cookie jar
https://bugs.webkit.org/show_bug.cgi?id=34878

Attachment 48627: v1 patch
https://bugs.webkit.org/attachment.cgi?id=48627&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>

> Index: WebKit/chromium/src/ChromiumBridge.cpp
> ===================================================================
> --- WebKit/chromium/src/ChromiumBridge.cpp	(revision 54703)
> +++ WebKit/chromium/src/ChromiumBridge.cpp	(working copy)
> @@ -112,6 +113,17 @@ static WebWidgetClient* toWebWidgetClien
>      return chromeClientImpl->webView()->client();
>  }
>  
> +static WebCookieJar* getCookieJar(const Document* document)
> +{
> +    WebFrameImpl* frameImpl = WebFrameImpl::fromFrame(document->frame());
> +    if (!frameImpl || !frameImpl->client())
> +	   return 0;
> +    WebCookieJar* cookieJar = frameImpl->client()->cookieJar();
> +    if (!cookieJar)
> +	   cookieJar = webKitClient()->cookieJar();

This is temporary as to not break things during the transition, right?	If so,
add a FIXME.  If not, are we going to leave 2 ways to do this?	I'm not
completely against it, but lets not turn the WebKit API into Perl.