[webkit-reviews] review granted: [Bug 34877] Rename underscored identifiers in CSSParser.cpp : [Attachment 48623] Rename underscored identifiers in WebCore/css/CSSParser.cpp.

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Yuzo Fujishima
<yuzo at google.com>'s request for review:
Bug 34877: Rename underscored identifiers in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=34877

Attachment 48623: Rename underscored identifiers in WebCore/css/CSSParser.cpp.
https://bugs.webkit.org/attachment.cgi?id=48623&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
> +	   WebCore/css/CSSParser.cpp:574:  valid_primitive is incorrectly
named. Don't use
> +	   underscores in your identifier names.  [readability/naming] [4]
> +	   WebCore/css/CSSParser.cpp:1079:  is_valid is incorrectly named.
Don't use
> +	   underscores in your identifier names.  [readability/naming] [4]

I'm not sure if we need these 4 lines in ChangeLog.

> +	   No new tests are required.

It would be better to say the reason why we don't need new tests.