[webkit-reviews] review requested: [Bug 34861] Web Inspector: Focusing a resource in the inspector should default to content not header : [Attachment 48603] [PATCH] Default to Content Tab

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 34861: Web Inspector: Focusing a resource in the inspector should default
to content not header
https://bugs.webkit.org/show_bug.cgi?id=34861

Attachment 48603: [PATCH] Default to Content Tab
https://bugs.webkit.org/attachment.cgi?id=48603&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
The initial default is "headers" (from Settings.js):

> this._installSetting("resourceViewTab", "resource-view-tab", "headers");

But the relevant code does look at the last user action (from ResourceView.js):


> _selectTab: function()
> {
>     if (this._headersVisible) {
>	  if (WebInspector.settings.resourceViewTab === "headers")
>	      this._selectHeadersTab();
>	  else
>	      this._selectContentTab();
>     } else
>	  this._innerSelectContentTab();
> },

Sounds like we should just empty out the default, or change it to something
like "content" to make it future proof for more tabs. Patch uses "content".