[webkit-reviews] review requested: [Bug 34382] When a live iframe element is moved between pages, it still depends on the old page. : [Attachment 48600] Updated patch.

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 34382: When a live iframe element is moved between pages, it still depends
on the old page.
https://bugs.webkit.org/show_bug.cgi?id=34382

Attachment 48600: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=48600&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Thanks all for great feedback. Updated patch:

- [Qt] removed public method from QWebFrame, it should not be a new API. Moved
it to QWebFramePrivate
- [Qt] now emit signal, QWebFrame::webPageChanged() when frame moves between
pages.
- [Chromium] added virtual
WebFrameClient::didTransferChildFrameToNewDocument(WebDocument) to signal the
embedder the frame was reparented.
- renamed FrameLoaderClient::adoptFrame(Frame*) to
FrameLoaderClient::didTransferChildFrameToNewDocument(Document*), renamed
corresponding Frame method as well.
- FrameLoaderClient::didTransferChildFrameToNewDocument(Document*) is now
called on the frame loader client of the transferred frame, rather then on the
client of the new parent frame.
- removed notImplemented() as suggested by Dave, I agree there is nothing 'not
implemented' there as we know.
- fiksed some typos.
- test is unchanged

I'll wait for r+ from Dave and also OK from Kenneth or Simon and Darin Fisher,
on Qt and Chromium code in particular.