[webkit-reviews] review denied: [Bug 34828] build-webkit doesn't work with VS2008 and VS2010 : [Attachment 48545] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 11 12:40:36 PST 2010


Adam Roben (aroben) <aroben at apple.com> has denied Eugene Lavrenov
<evgenilv at yahoo.ca>'s request for review:
Bug 34828: build-webkit doesn't work with VS2008 and VS2010
https://bugs.webkit.org/show_bug.cgi?id=34828

Attachment 48545: Patch
https://bugs.webkit.org/attachment.cgi?id=48545&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
As previously requested, please upload a unified diff instead of a zip file, as
described here: <http://webkit.org/coding/contributing.html>.

Also, please split this patch up into two pieces: one that fixes build-webkit
(which should be attached to this bug), and one that fixes the compiler
warnings (which should be attached to bug 34804).


More information about the webkit-reviews mailing list