[webkit-reviews] review denied: [Bug 32479] Improve portability of LayoutTests/fast/forms/validationMessage.html : [Attachment 44831] Proposed patch (rev.2)

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has denied TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 32479: Improve portability of LayoutTests/fast/forms/validationMessage.html
https://bugs.webkit.org/show_bug.cgi?id=32479

Attachment 44831: Proposed patch (rev.2)
https://bugs.webkit.org/attachment.cgi?id=44831&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
I think it's still unclear why we need this change. That's probably why it sits
for so long in the queue. Is there a version of DRT on some platform that
outputs different strings in English? Is there a DRT that can not be set to
output English-language messages?

Since we are talking about DRT running LayoutTests, and not actual browsers, it
seems DRT could always output same messages. I think it would help if you'd
explain the motivation behind this patch in more detail.

Also, the test as proposed seems to be checking less: for example, it would
indicate success if instead of "value missing' the code returns 'pattern
mismatch' and vice versa, since it just checks that the strings are different.

I'm going to r- this patch to temporarily move it out of the queue, looking for
more details on motivation behind it and perhaps a test that is at least as
'strict' as original one.