[webkit-reviews] review denied: [Bug 34836] [Android] V8 generated files V8HTMLCollection.cpp and V8HTMLAllCollection.cpp need to include V8Node.h : [Attachment 48557] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 11 08:40:32 PST 2010


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Steve Block
<steveblock at google.com>'s request for review:
Bug 34836: [Android] V8 generated files V8HTMLCollection.cpp and
V8HTMLAllCollection.cpp need to include V8Node.h
https://bugs.webkit.org/show_bug.cgi?id=34836

Attachment 48557: Patch
https://bugs.webkit.org/attachment.cgi?id=48557&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Per IM discussion, the right approach here is to make sure V8Node is correctly
included whenever setCollectionIndexedGetter template is used, because it in
turn uses toV8.


More information about the webkit-reviews mailing list