[webkit-reviews] review denied: [Bug 34829] [gtk] WebKitDownload's currentSize property is guint, should be guint64 : [Attachment 48546] Quick *blind* fix

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Diego Escalante Urrelo
<diegoe at gnome.org>'s request for review:
Bug 34829: [gtk] WebKitDownload's currentSize property is guint, should be
guint64
https://bugs.webkit.org/show_bug.cgi?id=34829

Attachment 48546: Quick *blind* fix
https://bugs.webkit.org/attachment.cgi?id=48546&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Your patch works. You get a warning on line 758, though, which you should fix
before we land this (because Soup behaves correctly, and handles us a goffset
instead). I wonder if we could move all our file size usage in WebKitDownload
to goffset to be consistent/correct. I don't know why I didn't do that in the
first place =(.