[webkit-reviews] review denied: [Bug 34833] Chromium DevTools: Trying to generate heap snapshots fast will generate more than expected : [Attachment 48552] proposed fix

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 34833: Chromium DevTools: Trying to generate heap snapshots fast will
generate more than expected
https://bugs.webkit.org/show_bug.cgi?id=34833

Attachment 48552: proposed fix
https://bugs.webkit.org/attachment.cgi?id=48552&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Minor nits, otherwise r+.

> +    this.lastRequestedLogPosition_ = -1;

this._lastRequestedLogPosition

> + */
> +devtools.ProfilerAgent.prototype.getNextLogLines_ = function(immediately)
> +{

"Next" does not sound well with plurals. "Further"?

> +    if (this.lastRequestedLogPosition_ == this.logPosition_)

===

Now that the files are upstream, please fix naming of private fields.