[webkit-reviews] review requested: [Bug 34382] When a live iframe element is moved between pages, it still depends on the old page. : [Attachment 48543] Patch, fixed crashes.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 10 19:31:11 PST 2010


Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 34382: When a live iframe element is moved between pages, it still depends
on the old page.
https://bugs.webkit.org/show_bug.cgi?id=34382

Attachment 48543: Patch, fixed crashes.
https://bugs.webkit.org/attachment.cgi?id=48543&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
The crashes in Chromium and QT were caused by their WebKit layer assuming the
Frame always belongs to a given Page. When iframe is passed between documents,
it can also be passed between windows, which requires corresponding update in
WebKit layer.
This is acieved by adding FrameLoaderClient::adoptFrame(Frame*) method which is
called when Frame is moved in DOM.


More information about the webkit-reviews mailing list