[webkit-reviews] review denied: [Bug 34538] audio engine: add Complex number class : [Attachment 48516] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 10 16:13:17 PST 2010


Darin Adler <darin at apple.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 34538: audio engine: add Complex number class
https://bugs.webkit.org/show_bug.cgi?id=34538

Attachment 48516: Patch
https://bugs.webkit.org/attachment.cgi?id=48516&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I like everything about this except for the suffix Utilities. I think this file
would be just fine named Complex.h -- named after the typedef that's in it.

> +#include <stdio.h>

Why include this? We should not.

I'm going to say review- because I think we should not choose this filename.


More information about the webkit-reviews mailing list