[webkit-reviews] review denied: [Bug 34686] [Haiku] Improve MIME type data base implementation on Haiku : [Attachment 48299] Patch makes MIMETypeRegistry fall back to use system data base on Haiku

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 10 13:33:13 PST 2010


Eric Seidel <eric at webkit.org> has denied Stephan Aßmus <superstippi at gmx.de>'s
request for review:
Bug 34686: [Haiku] Improve MIME type data base implementation on Haiku
https://bugs.webkit.org/show_bug.cgi?id=34686

Attachment 48299: Patch makes MIMETypeRegistry fall back to use system data
base on Haiku
https://bugs.webkit.org/attachment.cgi?id=48299&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The mime type lines used to be sorted alphabetically.  Why change that?  There
is no performance benefit to your change.  The CPU on my cellphone can execute
a billion comparisons a second, so shortening the array walk by a few places is
no perf savings. :)


More information about the webkit-reviews mailing list