[webkit-reviews] review granted: [Bug 34490] REGRESSION(r52116): WebCore::ImageEventSender::dispatchPendingEvents() crashes in certain conditions : [Attachment 48455] proposed fix

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 34490: REGRESSION(r52116):
WebCore::ImageEventSender::dispatchPendingEvents() crashes in certain
conditions
https://bugs.webkit.org/show_bug.cgi?id=34490

Attachment 48455: proposed fix
https://bugs.webkit.org/attachment.cgi?id=48455&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
 116	     // Callers of this method do not need events dispatched.
 117	     if (!m_firedBeforeLoad) {

It's better if a function comments about what it will do, and not about what
its callers will do. Callers are unpredictable.

I'd move this comment to the header declaration of setImage: // Cancels any
pending beforeLoad and load events.

r=me