[webkit-reviews] review granted: [Bug 34777] [Qt] Make possible Qt DRT get a page number for element by ID : [Attachment 48487] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 10 04:55:31 PST 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Diego Gonzalez
<diego.gonzalez at openbossa.org>'s request for review:
Bug 34777: [Qt] Make possible Qt DRT get a page number for element by ID
https://bugs.webkit.org/show_bug.cgi?id=34777

Attachment 48487: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=48487&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

>  
> +int QWEBKIT_EXPORT qt_drt_pageNumberForElementById(QWebFrame* qFrame, const
QString& id, float width, float height)
> +{
> +    Frame* frame = QWebFramePrivate::core(qFrame);
> +    if (!frame)

I would have used frame and coreFrame :-)
> +int LayoutTestController::pageNumberForElementById(const QString& id, float
width, float height)
> +{
> +    // If no size specified, webpage viewport size is used
> +    if (!width && !height) {
> +	   width = m_drt->webPage()->viewportSize().width();
> +	   height = m_drt->webPage()->viewportSize().height();
> +    }

What is with is 0, but height is not?


More information about the webkit-reviews mailing list