[webkit-reviews] review denied: [Bug 34782] Normalize custom ctors for Image, Option, Audio : [Attachment 48457] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Yaar Schnitman <yaar at chromium.org>'s
request for review:
Bug 34782: Normalize custom ctors for Image, Option, Audio
https://bugs.webkit.org/show_bug.cgi?id=34782

Attachment 48457: Patch
https://bugs.webkit.org/attachment.cgi?id=48457&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is *so* funny. I have a similar patch on my machine that I started working
on earlier today. I chose to emphasize the fact that the create functions are
for use with JavaScript constructors by using the name createForJSConstructor
rather than just create for them. And I did the work for WebKit's built-in
JavaScript engine too, not just for V8. As you should.

You're also using some non-standard formatting here. In the WebKit project we
do not put each argument of a function on a separate line, even if there are
many of them.

The arguments should be "const String&" rather than "String". And we name
things "document", not "doc", in new code at least.

And we don't use PassRefPtr for local variables.