[webkit-reviews] review granted: [Bug 33093] [Qt] LayoutTests/fast/html/text-field-input-types.html : [Attachment 48344] fix patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 33093: [Qt] LayoutTests/fast/html/text-field-input-types.html
https://bugs.webkit.org/show_bug.cgi?id=33093

Attachment 48344: fix patch
https://bugs.webkit.org/attachment.cgi?id=48344&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Hum...	I think this patch is correct.	There's a separate question of whether
you want the Qt metrics to match Mac, but that's not what this test is trying
to test, so I think that's better dealt with separately.

I agree that it's possible we should improve the text dumping to be immune to
these issues.  If this issue recurs, we can revisit that question.

BTW, it would be helpful if you'd copy more of your analysis from Comment #0
into the ChangeLog.  I found Comment #0 quite informative but you ChangeLog
somewhat mysterious.