[webkit-reviews] review denied: [Bug 34739] update run-chromium-webkit-tests to work w/ chromium-linux, chromium-win : [Attachment 48384] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 34739: update run-chromium-webkit-tests to work w/ chromium-linux,
chromium-win
https://bugs.webkit.org/show_bug.cgi?id=34739

Attachment 48384: Patch
https://bugs.webkit.org/attachment.cgi?id=48384&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+ port_to_use

There are some whitespace errors around the above.

+ Working around a race in Python 2.4's implementation of Popen().

Huh?  This doesn't look right.	We either need a more detailed comment or to
call the API in another way that avoids the race.  This just looks like it will
be buggy.  Maybe we need to call wait() at some point?	We do something similar
in webkit-patch somewhere.

The rest of the patch LGTM.  Maybe land the rest and re-visit the Popen issue
later?