[webkit-reviews] review requested: [Bug 34560] Typedef both JSChar and UChar to wchar_t in RVCT. : [Attachment 48423] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 9 09:24:18 PST 2010


Kwang Yul Seo <kwangyul.seo at gmail.com> has asked  for review:
Bug 34560: Typedef both JSChar and UChar to wchar_t in RVCT.
https://bugs.webkit.org/show_bug.cgi?id=34560

Attachment 48423: Patch
https://bugs.webkit.org/attachment.cgi?id=48423&action=review

------- Additional Comments from Kwang Yul Seo <kwangyul.seo at gmail.com>
Typedef both JSChar and UChar to wchar_t in RVCT. UnicodeQt4.h is modified to
define UChar to wchar_t for RVCT.

Don't use COMPILER(RVCT) guard in JavaScriptCore/API/JSStringRef.h as it breaks
the gtk port. Use defined(__CC_ARM) || defined(__ARMCC__) instead.


More information about the webkit-reviews mailing list