[webkit-reviews] review requested: [Bug 34019] Custom-written JavaScript parser : [Attachment 48409] template based approach

[bugzilla-daemon at webkit.org]

Zoltan Herczeg <zherczeg at webkit.org> has asked	for review:
Bug 34019: Custom-written JavaScript parser
https://bugs.webkit.org/show_bug.cgi?id=34019

Attachment 48409: template based approach
https://bugs.webkit.org/attachment.cgi?id=48409&action=review

------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
Finally finished. Actually, this was the hardest work so far. Darin's
prediction was right, the speed of this approach is nearly as fast as the
separate grammar syntax checker approach (32.6ms up from 32.2ms). Besides, the
code is nearly as big :) Regardless, I think this is the best choice between
speed and maintainability.

I have a small design question. I know C++ inlines functions inside a class
definition, but still, I like to put an ALWAYS_INLINE macro before the
definition to stress that I want it to be an inline function. This information
can be useful for those, who want to change the code. What is WebKit's policy
here? (I couldn't find anything about it in the coding guidelines)