[webkit-reviews] review granted: [Bug 34727] Assertion crashes and freezes when plug-in property access results in an exception : [Attachment 48367] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 8 15:18:59 PST 2010


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 34727: Assertion crashes and freezes when plug-in property access results
in an exception
https://bugs.webkit.org/show_bug.cgi?id=34727

Attachment 48367: proposed fix
https://bugs.webkit.org/attachment.cgi?id=48367&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>      static void setGlobalException(JSC::UString exception);

Maybe this argument name should be a const &, but that's not new to your code.

> +    static void moveGlobalExceptionToExecState(ExecState* exec);

You should omit the argument name there.

r=me


More information about the webkit-reviews mailing list