[webkit-reviews] review denied: [Bug 34706] Web Inspector: Continue with debugger and profiler unforking : [Attachment 48335] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 8 09:48:59 PST 2010
Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 34706: Web Inspector: Continue with debugger and profiler unforking
https://bugs.webkit.org/show_bug.cgi?id=34706
Attachment 48335: proposed patch
https://bugs.webkit.org/attachment.cgi?id=48335&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
r- for the bot failure.
+ #elif ENABLE(JAVASCRIPT_DEBUGGER)
+ , m_profilerEnabled(true)
It would be more clear if m_profilerEnabled was mentioned only once and resided
in a simple ENABLE(JAVASCRIPT_DEBUGGER) section.
Also please do not mix formatting with changes that heavily.
More information about the webkit-reviews
mailing list