[webkit-reviews] review denied: [Bug 34664] [Chromium] Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient : [Attachment 48268] Rename autocomplete* to suggestions* to prepare for the refactoring of AutocompletePopupMenuClient [try6]

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied James Hawkins
<jhawkins at google.com>'s request for review:
Bug 34664: [Chromium] Rename autocomplete* to suggestions* to prepare for the
refactoring of AutocompletePopupMenuClient
https://bugs.webkit.org/show_bug.cgi?id=34664

Attachment 48268: Rename autocomplete* to suggestions* to prepare for the
refactoring of AutocompletePopupMenuClient [try6]
https://bugs.webkit.org/attachment.cgi?id=48268&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebView.h

> -    // Hides the autofill popup if any are showing.
> -    virtual void hideAutofillPopup() = 0;
> +    // Hides the suggestions popup if any are showing.
> +    virtual void hideSuggestionsPopup() = 0;

Please preserve the old API, and add a comment marking it DEPRECATED.

You can just make your code call both functions for now.  Then, once
Chromium is updated to use the new function, you can come back and
delete the deprecated one.

Otherwise, LGTM.