[webkit-reviews] review granted: [Bug 32717] Support frameset flattening : [Attachment 46904] Patch with 5 test which all pass on Qt

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 32717: Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717

Attachment 46904: Patch with 5 test which all pass on Qt
https://bugs.webkit.org/attachment.cgi?id=46904&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
In the FrameView code:

"/ In flat frame layout mode the content of frame affects layout of the parent
frames."

Change that to "the contents of the frame"

"Invalidate also parent frame starting from"

Change to:

"Also invalidate the parent frame starting from"


In RenderFrame:

"NOTE: width and height has been set at this point by"

Change to:

"NOTE: The width and height have been set at this point by"

I think this would be useful to test on Mac as well if you wanted to add the
setting and patch more layout test controllers. That could happen in a followup
though.

r=me with those comments fixed up.