[webkit-reviews] review denied: [Bug 34600] [BREWMP] Port PlatformMouseEvent : [Attachment 48151] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 34600: [BREWMP] Port PlatformMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=34600

Attachment 48151: Patch
https://bugs.webkit.org/attachment.cgi?id=48151&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/platform/PlatformMouseEvent.h
> @@ -55,6 +55,12 @@ class wxMouseEvent;
>  class BMessage;
>  #endif
>  
> +#if PLATFORM(BREWMP)
> +typedef unsigned short    uint16;
> +typedef unsigned long int uint32;
> +#define AEEEvent uint16

Why doesn't this use a typedef (instead of a define)?

> +#if PLATFORM(BREWMP)
> +	   PlatformMouseEvent(AEEEvent event, uint16 wParam, uint32 dwParam);

The param name event is not needed here.