[webkit-reviews] review requested: [Bug 34019] Custom-written JavaScript parser : [Attachment 48223] Merging syntax checker and grammar
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 5 05:20:11 PST 2010
Zoltan Herczeg <zherczeg at webkit.org> has asked for review:
Bug 34019: Custom-written JavaScript parser
https://bugs.webkit.org/show_bug.cgi?id=34019
Attachment 48223: Merging syntax checker and grammar
https://bugs.webkit.org/attachment.cgi?id=48223&action=review
------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
The merge is done, although I am not sure this is a step ahead, since it is
slower.
*1.028x as slow* 32.6ms +/- 1.1% 33.5ms +/- 2.1% significant
I feel the code can be improved (and fast/js/function-dot-arguments.html
fails), but first I would like to hear your opinion whether I should continue
this work or step back to the previous patch.
Besides, is the parser layout test OK?
More information about the webkit-reviews
mailing list