[webkit-reviews] review granted: [Bug 34572] [Gtk] Implement layoutTestController.pageNumberForElementById : [Attachment 48131] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 5 03:52:52 PST 2010


Gustavo Noronha (kov) <gns at gnome.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 34572: [Gtk] Implement layoutTestController.pageNumberForElementById
https://bugs.webkit.org/show_bug.cgi?id=34572

Attachment 48131: Patch v1
https://bugs.webkit.org/attachment.cgi?id=48131&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
I was going to say the function name lacked a 'get' somewhere, to be
consistent, but I see we have previous cases of that; we might want to review
all of them while exposing. Thanks for the patch!


More information about the webkit-reviews mailing list