[webkit-reviews] review requested: [Bug 33875] [Qt] QWebPage::userAgentForUrl is terrible API : [Attachment 48217] Second attempt with a unit test.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 5 02:57:34 PST 2010


Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 33875: [Qt] QWebPage::userAgentForUrl is terrible API
https://bugs.webkit.org/show_bug.cgi?id=33875

Attachment 48217: Second attempt with a unit test.
https://bugs.webkit.org/attachment.cgi?id=48217&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Same patch with a unit test for the new API. The unit tests tests:
     1.) That the old behaviour is default
     2.) Setting a user agent is effective
     3.) Setting an empty user agent goes back to the old behavior.


More information about the webkit-reviews mailing list