[webkit-reviews] review denied: [Bug 34569] Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0 : [Attachment 48192] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 34569: Don't call CRASH() in fastMalloc and fastCalloc when the requested
memory size is 0
https://bugs.webkit.org/show_bug.cgi?id=34569

Attachment 48192: Patch
https://bugs.webkit.org/attachment.cgi?id=48192&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I don't see how checking after calling malloc is better than checking before
calling it. Normal case just gets one more branch either way, but fastMalloc(0)
is slower if you check after malloc returns 0.

We don't need to add the branch on platforms that don't return 0, please
protect the new code with preprocessor checks. Any future port that runs into
this can add themselves to the check.

>	  (WTF::fastRealloc):

You still had this in ChangeLog.