[webkit-reviews] review requested: [Bug 34569] Don't call CRASH() in fastMalloc and fastCalloc when the requested memory size is 0 : [Attachment 48192] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 4 19:53:58 PST 2010


Kwang Yul Seo <kwangyul.seo at gmail.com> has asked  for review:
Bug 34569: Don't call CRASH() in fastMalloc and fastCalloc when the requested
memory size is 0
https://bugs.webkit.org/show_bug.cgi?id=34569

Attachment 48192: Patch
https://bugs.webkit.org/attachment.cgi?id=48192&action=review

------- Additional Comments from Kwang Yul Seo <kwangyul.seo at gmail.com>
If malloc(0) returns NULL in fastMalloc, increase the size to 1 and retry. Do
the same for fastCalloc.

Leave out fastRealloc as it seems there is no code which calls fastRealloc(p,
0) currently. This needs to be discussed further in
https://bugs.webkit.org/show_bug.cgi?id=29026


More information about the webkit-reviews mailing list