[webkit-reviews] review denied: [Bug 34571] [Haiku] Implementation of browser shell : [Attachment 48128] Patch implementing HaikuLauncher browser shell.

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Stephan Aßmus <superstippi at gmx.de>'s
request for review:
Bug 34571: [Haiku] Implementation of browser shell
https://bugs.webkit.org/show_bug.cgi?id=34571

Attachment 48128: Patch implementing HaikuLauncher browser shell.
https://bugs.webkit.org/attachment.cgi?id=48128&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>

> +enum {
> +    HANDLE_SHUTDOWN			      = 'sdwn',
> +
> +    HANDLE_LOAD_URL			      = 'lurl',
> +    HANDLE_GO_BACK			     = 'back',
> +    HANDLE_GO_FORWARD		    = 'fwrd',
> +
> +    HANDLE_DRAW			      = 'draw',
> +
> +    HANDLE_FRAME_RESIZED		   = 'rszd'
> +};

This is incorrect, character literals should be a single character, this
triggers warnings in GCC and likely does not do what you are expecting.

Overall i'd also prefer this patch was split into multiple pieces so that it's
easier to review.