[webkit-reviews] review granted: [Bug 25002] Repeated copy/paste can lead to deeply nested divs : [Attachment 47892] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 25002: Repeated copy/paste can lead to deeply nested divs
https://bugs.webkit.org/show_bug.cgi?id=25002

Attachment 47892: Patch
https://bugs.webkit.org/attachment.cgi?id=47892&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Not your fault, but I hate it when code uses bools when we should be using
Enums:
 55	    NamedNodeMap* attributes =
curBlock->parentElement()->attributes(true);

I have no idea what that does w/o looking at the original function.

Turns out it means "readonly":
    NamedNodeMap* attributes(bool readonly) const;

But then that makes me wonder what plain old "attributes()" returns.  Bah!

Your change itself looks fine.	Looks like it does what it says it does, and
the test looks functional.