[webkit-reviews] review denied: [Bug 31248] Tab width for javascript source is 8, should be 4 : [Attachment 48176] Patch to convert tabs to 4 spaces

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 4 16:05:27 PST 2010


Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 31248: Tab width for javascript source is 8, should be 4
https://bugs.webkit.org/show_bug.cgi?id=31248

Attachment 48176: Patch to convert tabs to 4 spaces
https://bugs.webkit.org/attachment.cgi?id=48176&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Text editor does not support tabs yet. I'd like to keep it (and its model)
operating real characters with no tab substitutions for now.
There are good reasons for your change though, so if you are to make this
replace, please do it in the SourceFrame.js (setContent method).

Please also follow the patch submit guidelines (your change is missing
ChangeLog entry).


More information about the webkit-reviews mailing list