[webkit-reviews] review requested: [Bug 33383] REGRESSION (r52082): Missing event handlers on JQuery demo page (33383) : [Attachment 48175] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 4 15:17:52 PST 2010


Geoffrey Garen <ggaren at apple.com> has asked  for review:
Bug 33383: REGRESSION (r52082): Missing event handlers on JQuery demo page
(33383)
https://bugs.webkit.org/show_bug.cgi?id=33383

Attachment 48175: patch
https://bugs.webkit.org/attachment.cgi?id=48175&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
It turns out that we can't check in an XPath test until the XPath bug (bug
34231) is fixed, since the test will cause assertion failures. So, I've
uploaded the test to bug 34231.

Here's a new version of my patch, with "gc" renamed to "allocate", and an extra
assertion added for good measure.


More information about the webkit-reviews mailing list