[webkit-reviews] review denied: [Bug 34219] [Gtk] Server message not shown on http authentication : [Attachment 47947] Patch to make server message visible in http authentication dialog

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has denied José Millán Soto
<jmillan at igalia.com>'s request for review:
Bug 34219: [Gtk] Server message not shown on http authentication
https://bugs.webkit.org/show_bug.cgi?id=34219

Attachment 47947: Patch to make server message visible in http authentication
dialog
https://bugs.webkit.org/attachment.cgi?id=47947&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
A couple of things:

- You should probably create 2 or 3 rows depending or whether there's a realm
or not, not always create 3 and then not use the first one.

- You are checking that the string is not NULL, but I guess you should also
check that it's not ""?