[webkit-reviews] review denied: [Bug 18926] dt:after generate a line break. Boost documentation page renders poorly : [Attachment 47822] Do not assume that text is broken at pseudo/inline element boundaries, i.e., after :before, before :after, and before/after inline elements.

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Yuzo Fujishima <yuzo at google.com>'s request for
review:
Bug 18926: dt:after generate a line break. Boost documentation page renders
poorly
https://bugs.webkit.org/show_bug.cgi?id=18926

Attachment 47822: Do not assume that text is broken at pseudo/inline element
boundaries, i.e., after :before, before :after, and before/after inline
elements.
https://bugs.webkit.org/attachment.cgi?id=47822&action=review

------- Additional Comments from mitz at webkit.org
> +	       if (last != o && !last->isListMarker() &&
last->style()->styleType() != BEFORE && o->style()->styleType() != AFTER &&
!last->style()->isDisplayInlineType() && !o->style()->isDisplayInlineType()) {
> +		   // better to break between object boundaries than in the
middle of a word,
> +		   // except for list markers, :before pseudo elements, :after
pseudo elements, and inline elements.

I don’t see why you have to single-out :before and :after at all. Presumably
they are inlines too.

But the more I think about this, the less I think this “break between object
boundaries” case is ever the right thing to do. I think the handling of inline
and replaced elements in the main loop now correctly identifies breaking
opportunities, so this branch should never be taken.