[webkit-reviews] review granted: [Bug 34464] [Chromium] Chromium should receive checkbox state changes : [Attachment 48157] Updated with more comments from Darin
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 4 11:40:05 PST 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted
chris.guillory at google.com's request for review:
Bug 34464: [Chromium] Chromium should receive checkbox state changes
https://bugs.webkit.org/show_bug.cgi?id=34464
Attachment 48157: Updated with more comments from Darin
https://bugs.webkit.org/attachment.cgi?id=48157&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/accessibility/chromium/AXObjectCacheChromium.cpp
...
> +void AXObjectCache::postPlatformNotification(AccessibilityObject* obj,
AXNotification notification)
> {
> + if (!obj || !obj->documentFrameView() || notification !=
AXObjectCache::AXCheckedStateChanged)
nit: since you are within the namespace of AXObjectCache, there is no need
to use AXObjectCache::
otherwise, r=me
More information about the webkit-reviews
mailing list