[webkit-reviews] review requested: [Bug 34463] [Gtk] webkitgtk crashed when Orca open : [Attachment 48153] Patch: Make textForObject check if a render object is text before running toRenderText

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 4 09:57:59 PST 2010


José Millán Soto <jmillan at igalia.com> has asked  for review:
Bug 34463: [Gtk] webkitgtk crashed when Orca open
https://bugs.webkit.org/show_bug.cgi?id=34463

Attachment 48153: Patch: Make textForObject check if a render object is text
before running toRenderText
https://bugs.webkit.org/attachment.cgi?id=48153&action=review

------- Additional Comments from José Millán Soto <jmillan at igalia.com>
New version of the patch which do not have the "No new tests" line.

(In reply to comment #9)
> (From update of attachment 48058 [details])
> Rejecting patch 48058 from commit-queue.
>     The following ChangeLog files contain OOPS:
>     Please don't ever say "OOPS" in a ChangeLog file.

I thought that the "No new tests" line would be automatically removed when
reviewed. Sorry for the mistake :(

(In reply to comment #10)
> (In reply to comment #5)
> > tested with the patch,while tab amongst goole home page, still crashed:
> > 
> >    from
> >
/home/musi/webkitproject/trunk52853/WebKitBuild/Release/.libs/libwebkit-1.0.so.
2
> > (gdb) bt
> > #0	0x013a5740 in webkit_accessible_text_get_caret_offset(_AtkText*) ()
> >    from
> >
/home/musi/webkitproject/trunk52853/WebKitBuild/Release/.libs/libwebkit-1.0.so.
2
> > #1	0x00279f19 in atk_text_get_caret_offset () from
/usr/lib/libatk-1.0.so.0
> seem still crashed like this for second patch

Could not reproduce this crash.
However, if it crashed in that webkit_accessible_text_get_caret_offset i think
it may be a different bug.


More information about the webkit-reviews mailing list