[webkit-reviews] review granted: [Bug 34371] REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big : [Attachment 47759] Allow ScrollbarTheme to cap the overlap between pages, and set a cap of in ScrollbarThemeMac

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 34371: REGRESSION (r53718): When scrolling a tall window by page, the
overlap between pages is too big
https://bugs.webkit.org/show_bug.cgi?id=34371

Attachment 47759: Allow ScrollbarTheme to cap the overlap between pages, and
set a cap of in ScrollbarThemeMac
https://bugs.webkit.org/attachment.cgi?id=47759&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/platform/Scrollbar.h
> ===================================================================

> +    static int pixelsPerLineStep() { return 40; }
> +    static float minFractionToStepWhenPaging() { return 0.875f; }
> +    static int maxAmountToKeepWhenPaging();

I think I'd like to see "pixels" in the name of this method.I'm not super-keen
on "amount to keep" either, but can't think of a better term.