[webkit-reviews] review denied: [Bug 34387] GtkLauncher is not compiled : [Attachment 48073] Patch to fix WebKitGTK build when --enable-mathml specified.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 4 04:20:57 PST 2010
Shinichiro Hamaji <hamaji at chromium.org> has denied Clemmitt Sigler
<cmsigler at gmail.com>'s request for review:
Bug 34387: GtkLauncher is not compiled
https://bugs.webkit.org/show_bug.cgi?id=34387
Attachment 48073: Patch to fix WebKitGTK build when --enable-mathml specified.
https://bugs.webkit.org/attachment.cgi?id=48073&action=review
------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Thanks for sending this patch. This seems to be OK, but please add a ChangeLog
entry for your change. WebKitTools/Scripts/prepare-ChangeLog should do the
trick. Please read the following document for the detail.
http://webkit.org/coding/contributing.html
For the record, this is the corresponding change:
http://trac.webkit.org/changeset/53764
More information about the webkit-reviews
mailing list