[webkit-reviews] review granted: [Bug 34533] [Qt] QScriptValue autotests : [Attachment 48042] Autotests v1

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Jędrzej Nowacki
<jedrzej.nowacki at nokia.com>'s request for review:
Bug 34533: [Qt] QScriptValue autotests
https://bugs.webkit.org/show_bug.cgi?id=34533

Attachment 48042: Autotests v1
https://bugs.webkit.org/attachment.cgi?id=48042&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
> +void tst_QScriptValue::initScriptValues()
> +{
> +    m_values.clear();
> +    if (engine)
> +	   delete engine;

The if check is not necessary :)


Please also file bug reports against the style checker. Either we need to
exclude the files from the style check or perhaps it can be fixed to ignore
that particular rule in that file.