[webkit-reviews] review denied: [Bug 34519] [Qt] Applications using QtWebKit fail to build if Qt was built with -no-script : [Attachment 48013] Fix

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Bernhard Rosenkraenzer
<bero at arklinux.org>'s request for review:
Bug 34519: [Qt] Applications using QtWebKit fail to build if Qt was built with
-no-script
https://bugs.webkit.org/show_bug.cgi?id=34519

Attachment 48013: Fix
https://bugs.webkit.org/attachment.cgi?id=48013&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

> +#if !defined(QT_NO_SCRIPT) && !defined(BUILD_WEBKIT)
>      void addToJavaScriptWindowObject(const QString &name, QObject *object,
QScriptEngine::ValueOwnership ownership);
> +#endif

Why the check for BUILD_WEBKIT?

Also the Qt EWS bot indicates that this breaks the build because there's the
equivalent #ifdef missing in qwebframe.cpp.

(Yay for the EWS :)