[webkit-reviews] review denied: [Bug 34554] [V8] Move Element custom methods into generic bindings : [Attachment 48094] Patch--updates WebCore.gypi

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 4 02:32:50 PST 2010


Adam Barth <abarth at webkit.org> has denied Dominic Cooney
<dominicc at google.com>'s request for review:
Bug 34554: [V8] Move Element custom methods into generic bindings
https://bugs.webkit.org/show_bug.cgi?id=34554

Attachment 48094: Patch--updates WebCore.gypi
https://bugs.webkit.org/attachment.cgi?id=48094&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
In general, this looks good, but I do think V8BindingElement.h is too verbose,
as you mentioned in email.  We should find a place do do that as a typedef.

Also, we don't need V8Binding::Element since the generic bindings don't need to
call back to the V8 bindings.


More information about the webkit-reviews mailing list