[webkit-reviews] review requested: [Bug 34527] [Haiku] Improve/maintain Haiku port : [Attachment 48124] More robust conversion from BString to String.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 4 02:16:50 PST 2010


Stephan Aßmus <superstippi at gmx.de> has asked  for review:
Bug 34527: [Haiku] Improve/maintain Haiku port
https://bugs.webkit.org/show_bug.cgi?id=34527

Attachment 48124: More robust conversion from BString to String.
https://bugs.webkit.org/attachment.cgi?id=48124&action=review

------- Additional Comments from Stephan Aßmus <superstippi at gmx.de>
Another patch by Maxime Simone. It could be that this more robust conversion is
not needed anymore since some recent changes to Haiku's BString implementation.
However, since the Haiku API does not throw on allocation failures, checking
BString::String() against NULL is more correct indeed.


More information about the webkit-reviews mailing list