[webkit-reviews] review granted: [Bug 34524] [Chromium] Writing Direction context menu for OS X : [Attachment 48061] Fix style issues

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 34524: [Chromium] Writing Direction context menu for OS X
https://bugs.webkit.org/show_bug.cgi?id=34524

Attachment 48061: Fix style issues
https://bugs.webkit.org/attachment.cgi?id=48061&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebKit/chromium/public/WebContextMenuData.h
b/WebKit/chromium/public/WebContextMenuData.h

Should there be a "#if OS(DARWIN)" around this?

> +    enum CheckableMenuItemFlags {
> +	   CheckableMenuItemDisabled = 0x0,
> +	   CheckableMenuItemEnabled = 0x1,
> +	   CheckableMenuItemChecked = 0x2,
> +    };
> +
> +    // Writing direction menu items.
> +    // Currently only used on OS X.
> +    int writingDirectionDefault;
> +    int writingDirectionLeftToRight;
> +    int writingDirectionRightToLeft;