[webkit-reviews] review requested: [Bug 33684] check-webkit-style: Provide a way to specify filter rules on a per-file/folder basis : [Attachment 48066] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 3 13:48:51 PST 2010


Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 33684: check-webkit-style: Provide a way to specify filter rules on a
per-file/folder basis
https://bugs.webkit.org/show_bug.cgi?id=33684

Attachment 48066: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=48066&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
Sorry this patch is on the bigger side.

I'd like to break up ProcessorOptions into two classes next, as I've described
in the FIXME.

Also, I did a few scattered PEP8 touch-ups when I was near the code, but not
systematically.


More information about the webkit-reviews mailing list