[webkit-reviews] review requested: [Bug 34463] [Gtk] webkitgtk crashed when Orca open : [Attachment 48058] Patch: Make textForObject check if a render object is text before running toRenderText

[bugzilla-daemon at webkit.org]

José Millán Soto <jmillan at igalia.com> has asked  for review:
Bug 34463: [Gtk] webkitgtk crashed when Orca open
https://bugs.webkit.org/show_bug.cgi?id=34463

Attachment 48058: Patch: Make textForObject check if a render object is text
before running toRenderText
https://bugs.webkit.org/attachment.cgi?id=48058&action=review

------- Additional Comments from José Millán Soto <jmillan at igalia.com>
I think that the problem is that toRenderText is being executed without
checking if the object is a RenderText; and toRenderText will return an
RenderText* even if the object is not a RenderText (It checks if it's a
RenderText using ASSERT, but the returned value does not depend on whether the
object is a RenderText or not).

This patch checks if the object is a RenderText before executing toRenderText.