[webkit-reviews] review denied: [Bug 34527] Improve/maintain Haiku port : [Attachment 48025] This patch changes the MIMETypeRegistryHaiku implementation to fall back to the Haiku MIME database for unknown file extensions.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 3 10:56:43 PST 2010


David Levin <levin at chromium.org> has denied Stephan Aßmus
<superstippi at gmx.de>'s request for review:
Bug 34527: Improve/maintain Haiku port
https://bugs.webkit.org/show_bug.cgi?id=34527

Attachment 48025: This patch changes the MIMETypeRegistryHaiku implementation
to fall back to the Haiku MIME database for unknown file extensions.
https://bugs.webkit.org/attachment.cgi?id=48025&action=review

------- Additional Comments from David Levin <levin at chromium.org>
All of these patches need changelogs. See
http://webkit.org/coding/contributing.html (prepare-ChangeLog is the command).
Please look at other entries in the ChangeLog to note typical formatting.

Here's some details on ChangeLog formatting:
Leave the Reviewed by NOBODY (OOPS) but remove the no tests oops and either say
what tests cover the change or why there are no tests added.

Other typical formatting is

  Bug Title
  Bug Link

  Small description or even better function by function small descriptions of
the changes done (see other changelog entries for good examples).


More information about the webkit-reviews mailing list